Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #740 we were debugging FTP access for the Pangeo hub required for Ryan's class. This produced #741 for discussion around long-term fixes for how we handle network policies.
This PR represents part of the work we did to debug the FTP issue. It brings the singleuser network policies from the daskhub values file into the the pangeo-hubs config file and add the FTP port (21 with TCP protocol).
Note: It is necessary to copy the whole network policy block as helm does not allow appending of array items, only over-writing. So we have to redefine everything we want to keep. This will be easier to maintain if/when we move to having a permissive network policy by default and allowing an opt-in model for restrictions on a per-hub basis, as discussed here.
Note: This PR currently does not fix the FTP issue but has made some progress towards a solution.
Error message without this PR:
Error message with this PR:
This is because the FTP request is working passive mode where a second, random port connection is opened for the data. berkeley-dsep-infra/datahub#2825 contains some info on this issue for me to follow up on.
Update: Reading this thread, seems like the only viable option is to open all outbound ports due to random port allocation FTP does.