Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old checkpoint deletion by sorting the models properly #89

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Lordmau5
Copy link
Contributor

@Lordmau5 Lordmau5 commented Mar 23, 2023

Should fix #65 this time around.
The reason why this didn't work before is because it sorted them based on their name or time alone, but not also based on their prefix, so the resulting array looked like "G_", "D_", "G_", "D_", ...

This addresses that by also sorting based on their prefix, resulting in a properly sorted array "G_", "G_", "G_", "D_", "D_", "D_"

This has to be done this way due to how the itertools.groupby method works: https://note.nkmk.me/en/python-itertools-groupby/

Edit: Started training a new model from scratch with these code-changes, it's clearing it correctly
image

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2023

Codecov Report

Merging #89 (e6b5bf7) into main (9ffb621) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   16.96%   16.80%   -0.17%     
==========================================
  Files          28       28              
  Lines        3359     3391      +32     
  Branches      385      393       +8     
==========================================
  Hits          570      570              
- Misses       2778     2810      +32     
  Partials       11       11              
Impacted Files Coverage Δ
src/so_vits_svc_fork/utils.py 17.91% <0.00%> (-0.06%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@34j
Copy link
Collaborator

34j commented Mar 24, 2023

Thanks for your PR. However, it needs to be modified as it cannot be merged if the ci (except codecov) is not passed. (Please run pre-commit.) Also, please use path.stem instead of .name as much as possible.

@Lordmau5 Lordmau5 force-pushed the fix-old-checkpoint-deletion branch from c9c1563 to e6b5bf7 Compare March 24, 2023 11:24
@34j 34j self-requested a review March 24, 2023 12:40
@34j 34j merged commit 287dc94 into voicepaw:main Mar 24, 2023
@34j
Copy link
Collaborator

34j commented Mar 24, 2023

@allcontributors add Lordmau5 bug, code

@allcontributors
Copy link
Contributor

@34j

I've put up a pull request to add @Lordmau5! 🎉

@Lordmau5 Lordmau5 deleted the fix-old-checkpoint-deletion branch March 24, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"keep_ckpts" not working
3 participants