Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename DatabaseResource.connect to connection #149

Open
balazsdukai opened this issue Feb 8, 2025 · 0 comments
Open

Rename DatabaseResource.connect to connection #149

balazsdukai opened this issue Feb 8, 2025 · 0 comments

Comments

@balazsdukai
Copy link
Member

balazsdukai commented Feb 8, 2025 •
edited
Loading

Because .connect is a property and it returns a DatabaseConnection without doing much. Property names should be nouns, hence "connection". .connect is a verb and it implies a method and some activity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balazsdukai