Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn on warnings by default #88

Closed
ArthurBandaryk opened this issue Oct 6, 2021 · 0 comments · Fixed by #94
Closed

Turn on warnings by default #88

ArthurBandaryk opened this issue Oct 6, 2021 · 0 comments · Fixed by #94
Assignees

Comments

@ArthurBandaryk
Copy link
Contributor

ArthurBandaryk commented Oct 6, 2021

We need to turn all warnings into errors (-Werror compiler option). It would make us fix all warnings except deprecated-declarations warning. For now we have warning about syscall, in future we are going to fix this too. You can see this issue on the screen below.
Screen Shot 2021-10-07 at 12 24 16 PM

Thus, with the help of the command below we will be able to clean our builds from warnings (again: except syscall warning):
bazel build --copt="-Werror" --copt="-Wno-error=deprecated-declarations" :eventuals

@ArthurBandaryk ArthurBandaryk self-assigned this Oct 6, 2021
This was linked to pull requests Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant