Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include template for Redis for OAuth flow (Openshift) #300

Closed
kevprice83 opened this issue Mar 14, 2017 · 6 comments
Closed

Include template for Redis for OAuth flow (Openshift) #300

kevprice83 opened this issue Mar 14, 2017 · 6 comments

Comments

@kevprice83
Copy link
Member

kevprice83 commented Mar 14, 2017

Solution

Use the redis template from Origin upstream

Unfortunately this won't work "as is" for APIcast deployed on OpenShift. So the following changes need to be made.

  • Either an ImageStream needs to be created or directly editing the config for Redis to include the URL of the registry where the image is hosted. Without this change in the default template the deployment config cannot pull the image.

  • Also the default template includes setting a password to access the Redis instance.

    • Either the gateway logic needs to be updated to grab this value from the ENV and execute all Redis actions with the password or remove the password completely from the template as I have done in my template

We should cover in more detail the documentation of the specifically setting this up in OpenShift as the OAuth flow is a bit trickier to set up here than native deployment for example.

@mikz
Copy link
Contributor

mikz commented Mar 14, 2017

APIcast is indeed missing password support in redis.
OpenShift example redis example not working is not APIcast problem at all.

Did you try to set the password to empty by using --param REDIS_PASSWORD="" when importing the template? Haven't tried just, so no idea if it works or still generates new password.

@mayorova
Copy link
Contributor

I've used this modified apicast template to deploy Redis: https://gist.github.com/mayorova/9825ebea7885335c5540c027023474c8

@kevprice83
Copy link
Member Author

It's not an APIcast problem right, but we have a dependency on Redis so I think it makes sense we provide a template to make that work in our deployment option on OpenShift. I just wanted to share how I made that work along with the issue itself. So let me reword the issue itself so it seems more appropriate here.

I did remove the password but the template sets the REDIS_PASSWORD as en ENV so all of these parameters need to be removed from the config.

@mikz
Copy link
Contributor

mikz commented Mar 14, 2017

When importing the template you can set params otherwise they are generated. If you'd set REDIS_PASSWORD as a param all that should be set to empty password and possibly work.

Anyway, we should add password support. Probably with unifying the configuration into an url: redis://password@host:port/db.

@mikz
Copy link
Contributor

mikz commented Mar 15, 2017

We are going to support password in Redis connection #301 + #303. So this should be changed to pure documentation issue.

@davidor
Copy link
Contributor

davidor commented Nov 6, 2018

The OAuth flow is deprecated. Closing.

@davidor davidor closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants