[t] use one base class #458
Conversation
Generated by 🚫 Danger |
mikz
force-pushed
the
test-base-class
branch
4 times, most recently
from
361a2b0
to
7e158ea
Compare
apicast/src/configuration.lua
Outdated
|
|
||
| local empty_t = readonly_table() | ||
|
|
||
| local function backend_endpoint(proxy) |
There was a problem hiding this comment.
The indentation here is not consistent with the rest of the codebase.
There was a problem hiding this comment.
Indeed. Haven't configured my IDE and used the default 4 spaces indentation.
Must admit that I quite like it. Somehow it makes it more readable. Also the OpenResty code is indented with 4 spaces.
I'd consider switching to 4 spaces. Wdyt?
There was a problem hiding this comment.
I don't mind as long as it's spaces :) and we are consistent across the codebase.
http://lua-users.org/wiki/LuaStyleGuide
|
|
||
| my $pwd = cwd(); | ||
| my $apicast = $ENV{TEST_NGINX_APICAST_PATH} || "$pwd/apicast"; | ||
| use TestAPIcast 'no_plan'; |
There was a problem hiding this comment.
I don't really know. I guess it defines in what order to execute the tests. Search for plan on http://search.cpan.org/~agent/Test-Nginx/lib/Test/Nginx/Socket.pm
https://openresty.gitbooks.io/programming-openresty/content/ also have few mentions of it.
| env_to_nginx( | ||
| 'RESOLVER' | ||
| ); | ||
| master_on(); | ||
| log_level('debug'); | ||
| repeat_each(1); |
There was a problem hiding this comment.
Should we define TEST_NGINX_REPEAT_EACH instead?
From TestAPIcast: repeat_each($ENV{TEST_NGINX_REPEAT_EACH} || 2);
There was a problem hiding this comment.
Some tests force one iteration because 2nd one would hit cache and have different result.
Because the repeat_each is in the base this is an override. So all tests default to 2 (or the env var) except few ones that are forced to one.
| @@ -0,0 +1,74 @@ | |||
| package TestAPIcast; | |||
| @@ -45,6 +45,7 @@ jobs: | |||
| working_directory: /opt/app-root/apicast | |||
| steps: | |||
| - checkout | |||
| - run: rm -rf lua_modules | |||
There was a problem hiding this comment.
Why is this needed now, but not before? 🤔
There was a problem hiding this comment.
It is needed for local run. There is no way to ignore folders on local build.
unify all tests to use one base
so we can share setting between tests