[nginx] define resolver directive in the config #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
Nov 28, 2017
| local insert = table.insert | ||
| local concat = table.concat | ||
| local re = require('ngx.re') | ||
|
|
||
| local function parse_nameservers() |
There was a problem hiding this comment.
Shouldn't this method be exposed in resty.resolver?
There was a problem hiding this comment.
resty.resolver exposes the nameservers as tables with some metamethods. Those objects can be joined with table.join so they have to be serialized first into ip:port. I guess it is worth a comment in the code. Will fix it.
davidor
reviewed
Nov 28, 2017
|
|
||
| for _,nameserver in ipairs(resolver.init_nameservers()) do | ||
| -- resty.resolver returns nameservers as tables with __tostring metamethod | ||
| -- unfrotunately those objects can't be joined with table.concat |
so cosockets use internal resolver and don't have to go through APIcast resolver. Closes #488
davidor
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so cosockets use internal resolver and don't have to
go through APIcast resolver.
Closes #488