Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect param value in the Echo policy #684

Merged
merged 3 commits into from
Apr 26, 2018
Merged

Fix incorrect param value in the Echo policy #684

merged 3 commits into from
Apr 26, 2018

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Apr 26, 2018

The code was assuming that valid values for exit were request and set. However, valid values according to the schema are request and set. The latter was changed in the schema by mistake.

@davidor davidor requested a review from mikz April 26, 2018 12:38
mikz
mikz approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@davidor davidor merged commit e0fcc91 into master Apr 26, 2018
@davidor davidor deleted the fix-echo-policy-incorrect-exit-values branch April 26, 2018 13:56
mikz pushed a commit that referenced this pull request May 11, 2018
@davidor @mikz
Merge pull request #684 from 3scale/fix-echo-policy-incorrect-exit-va…
8553bdb 
…lues

Fix incorrect param value in the Echo policy
@mikz mikz mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikz mikz mikz approved these changes

Assignees

@davidor davidor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidor @mikz