[THREESCALE-852] Split upstream policy phases so it can match the original path #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way this policy will be easier to combine with others, for example the URL rewriting policy. Before this change, the upstream policy ran on the content phase, whereas the URL rewriting one ran on the rewrite phase. This means that the upstream policy always took into account the rewritten path instead of the original one, regardless of the position of the policies in the chain. This commit fixes the issue.
… with upstream policy It no longer applies.
…he upstream policy
davidor
force-pushed
the
split-upstream-policy-phases
branch
from
53756c2
to
7889cba
Compare
mikz
reviewed
May 9, 2018
| context.upstream_changed = true | ||
| return change_upstream(rule.url) | ||
| elseif ngx.config.debug then | ||
| context.new_upstream = rule.url |
There was a problem hiding this comment.
At some point we should introduce policy local context per request for these variables.
mikz
approved these changes
May 9, 2018
mikz
added a commit
that referenced
this pull request
May 11, 2018
[THREESCALE-852] Split upstream policy phases so it can match the original path
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the same problem that #689 solves but in a different way.
This PR modifies the Upstream policy so the matching of rules is done in the rewrite phase instead of the content one. This allows us to combine this policy with the URL rewriting one. Before this change, the upstream policy ran on the content phase, whereas the URL rewriting one ran on the rewrite phase. This means that the upstream policy always took into account the rewritten path instead of the original one, regardless of the position of the policies in the chain.
I opened a new PR instead of fixing the previous one because I think @nmasse-itix might need it until we merge this.
Ref: https://issues.jboss.org/browse/THREESCALE-852