Improve rate limit policy #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidor
reviewed
May 14, 2018
| @@ -23,18 +23,14 @@ | |||
| "scope": { | |||
| "type": "string", | |||
| "description": "Scope of the key", | |||
| "default": "global", | |||
| "default": "service", | |||
There was a problem hiding this comment.
I think this change of behavior should be documented in the changelog.
There was a problem hiding this comment.
This policy was included in a 'release candidate' version that can become final. If it does, this change will be included in the next release and be considered a breaking change. I think we should be clear about that in the changelog.
There was a problem hiding this comment.
@davidor I'm not sure if it is a breaking change. Just changing the default value will affect only new instances of this policy.
There was a problem hiding this comment.
You're right @mikz 👍
This is not a breaking change, sorry for the confusion.
|
Apart from what I commented above, the PR looks good to me 👍 |
davidor
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the rate limit policy according to the comments of PR #665.
From #703.