3scale batching policy: fix batching period assignment from config #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng the test If the report timer runs during the tests, it will alter the results. We set a batching period high enough to prevent this from happening, but as we cannot guarantee it, we need to check that it didn't happen.
davidor
changed the title
mikz
reviewed
May 15, 2018
| @@ -255,6 +255,7 @@ push $res, "Host: one"; | |||
| $res | |||
| --- no_error_log | |||
| [error] | |||
| 3scale batcher report timer got | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the 3scale batching policy. It didn't assign the batching period according to the given configuration.
While at it, this PR also adds some debugging logs and tests that helped to detect this issue.