Add "Retry-After" header #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioggstream
reviewed
Jan 24, 2019
| -- body has many information like metrics, limits, etc. This information is | ||
| -- parsed only when using oauth. By enabling this option will save some work | ||
| -- to the 3scale backend and reduce network traffic. | ||
| -- - limit_headers: when enabled and the request is rate-limited, backend | ||
| -- returns the number of seconds remaining until the limit expires. It | ||
| -- returns -1 when there are no limits. With this header, backend returns |
There was a problem hiding this comment.
@davidor https://tools.ietf.org/html/rfc7231#section-7.1.3
A delay-seconds value is a non-negative decimal integer, representing time in seconds.
In extensions.md I'd add a notice on that difference with the specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #335
This PR introduces a "Retry-After" header in the APIcast response.
When rate-limited by the 3scale backend, APIcast returns the number of seconds that the caller needs to wait before it's authorized again in the "Retry-After" header.