[THREESCALE-1781] Fix bug with proxied POST requests to HTTPS API backend via forward proxy #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot use resty.http's .get_client_body_reader(). In some POST requests with HTTPS, the result of that call is nil, and it results in a time-out.
davidor
force-pushed
the
https-proxy-with-post-req
branch
from
e1dc0b6
to
8d9c06c
Compare
mikz
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that happens when proxying POST requests to an HTTPS upstream when using HTTPS_PROXY.
We were using resty.http's
.get_client_body_reader(), but it looks like the result of that function isnilin this case.I just changed that call with
ngx.req.get_body_data(). The 2 tests added in this PR were failing before the change.Ref: https://issues.jboss.org/browse/THREESCALE-1781