Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests around Storm objects #162

Open
3 tasks
ryanbourneuk opened this issue Jul 23, 2019 · 0 comments
Open
3 tasks

Add unit tests around Storm objects #162

ryanbourneuk opened this issue Jul 23, 2019 · 0 comments
Assignees
Labels
codable-refactor Work relating to the Storm Codable refactor

Comments

@ryanbourneuk
Copy link
Contributor

ryanbourneuk commented Jul 23, 2019

Expected Behaviour

All Storm objects (objects that are generated from a Storm bundle) should have full unit test coverage.

Current Behaviour

Only some Storm objects have unit test coverage.

Possible Solution

  • Add #warnings around Storm objects & parsing to direct where tests should be added.
  • Migrate unit tests from an old stale Obj-c branch.
  • Add new tests to clear #warnings

Steps to Reproduce (for bugs)

Context

As part of the codable-refactor project, all Storm objects will be migrated from using manual JSON parsing / initialisation to using Codable. However, as ThunderCloud is used in many many apps, it'd be great for it to not break. If we determine the current state of ThunderCloud to be as expected, we can write a test suite against it - and then migrate objects to use Codable. The tests will then inform us if we have deviated from the expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codable-refactor Work relating to the Storm Codable refactor
Projects
None yet
Development

No branches or pull requests

1 participant