Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful combinators #51

Merged
merged 4 commits into from
Jul 4, 2017
Merged

Useful combinators #51

merged 4 commits into from
Jul 4, 2017

Conversation

noelmarkham
Copy link
Collaborator

Useful combinators for:

  • Ordering pairs
  • Distinct pairs
  • Ordered lists

Plus tests.

@raulraja @juanpedromoreno would you be able to take a look please?

@codecov-io
Copy link

codecov-io commented Jun 13, 2017

Codecov Report

Merging #51 into master will decrease coverage by 13.99%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master      #51    +/-   ##
========================================
- Coverage   97.16%   83.17%   -14%     
========================================
  Files          10       10            
  Lines         106      107     +1     
  Branches        0        4     +4     
========================================
- Hits          103       89    -14     
- Misses          3       18    +15
Impacted Files Coverage Δ
...ysevendeg/scalacheck/combinators/Combinators.scala 100% <100%> (ø) ⬆️
...ysevendeg/scalacheck/datetime/instances/jdk8.scala 0% <0%> (-100%) ⬇️
...scalacheck/datetime/jdk8/granularity/package.scala 73.33% <0%> (-26.67%) ⬇️
...scalacheck/datetime/joda/granularity/package.scala 73.33% <0%> (-26.67%) ⬇️
...rtysevendeg/scalacheck/datetime/joda/GenJoda.scala 76% <0%> (-18.45%) ⬇️
...ysevendeg/scalacheck/datetime/instances/joda.scala 100% <0%> (ø) ⬆️
...ala/com/fortysevendeg/scalacheck/magic/Magic.scala 100% <0%> (ø) ⬆️
...rtysevendeg/scalacheck/datetime/jdk8/GenJdk8.scala 100% <0%> (ø) ⬆️
...ortysevendeg/scalacheck/datetime/Granularity.scala 100% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91309ab...5224bd5. Read the comment docs.

Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems like you need to rebase from master though :)

Hopefully, the test coverage will increase, it's weird we're decreasing it ~14%

@noelmarkham noelmarkham merged commit c6891f3 into master Jul 4, 2017
@noelmarkham noelmarkham deleted the nm-32-combinators-new branch July 4, 2017 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants