Pulling in the magic strings from an online source

[noelmarkham]

This parses the data in the "big list of naughty strings" repo and provides a generator.

Originally I was trying to use a macro to parse the lines into a list, and I realised I didn't really need to do that :-/ ... I think the rationale behind that was to only have that list parsed once ever - at library compile time - but it wasn't really worth the effort when it can be done so simply when the Magic class is first referenced, I think this is a fine tradeoff.

@juanpedromoreno @fedefernandez what do you think?

[fedefernandez]

I'm okay with this approach.
Do you think it would need to be defined as lazy?
On the other hand, I'm not sure if the magic file will be packaged inside the jar

[noelmarkham]

I don't think lazy is necessary - if anything that's going the opposite way to which I'd want to go (ideally I want the list parsed at compile time as this only ever needs to be done once).

As for in the Jar, I assumed it would be as it's in the resources directory, but this is something that I should definitely test. Thanks!

[noelmarkham]

I've manually tested this and it works fine in a fresh project, pulling in the published Jar. I've created issue #55 to do the work to automate this.

If you're happy can I get a LGTM and I'll merge this.

Thanks!

[fedefernandez]

Should it be Scala 2.10 and 2.11 compatible? The method fromResource is only available from Scala 2.12

[noelmarkham]

Ah yes, this is masked by the multiple build issues I was planning to fix after this. I'm going to mark this PR as blocked until I've fixed #52

[codecov-io]

Codecov Report

Merging #54 into master will decrease coverage by 0.74%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #54      +/-   ##
=========================================
- Coverage   98.34%   97.6%   -0.75%     
=========================================
  Files          10      10              
  Lines         121     125       +4     
  Branches        4       4              
=========================================
+ Hits          119     122       +3     
- Misses          2       3       +1

Impacted Files	Coverage Δ
...ala/com/fortysevendeg/scalacheck/magic/Magic.scala	100% <100%> (ø)	⬆️
...ortysevendeg/scalacheck/datetime/GenDateTime.scala	80% <0%> (-20%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6891f3...16d7376. Read the comment docs.

[noelmarkham]

@fedefernandez are you able to review now please? This is working across Scala 2.[10, 11, 12].

Thanks

[fedefernandez]

LGTM!