Granularity #7
Merged
Granularity #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)@@ master #7 diff @@
===================================
Files 5 8 +3
Lines 35 76 +41
Methods 35 76 +41
Messages 0 0
Branches 0 0
===================================
+ Hits 35 76 +41
Misses 0 0
Partials 0 0
|
|
|
||
| val granularitiesAndPredicatesWithDefault: List[(Granularity[ZonedDateTime], ZonedDateTime => Boolean)] = (Granularity.identity[ZonedDateTime], (_: ZonedDateTime) => true) :: granularitiesAndPredicates | ||
|
|
||
| property("genZonedDateTime with a granularity generated appropriate ZonedDateTimes") = forAll(Gen.oneOf(granularitiesAndPredicates)) { case (granularity, predicate) => |
There was a problem hiding this comment.
Maybe a typo? generated -> generates
|
Minor comment. LGTM Great job @noelmarkham! |
| } | ||
| } | ||
|
|
||
| property("genDateTimeWithinRange for Java 8 should generate ZonedDateTimes between the given date and the end of the specified Duration") = forAll(genZonedDateTime, genDuration, Gen.oneOf(granularitiesAndPredicatesWithDefault)) { case (now, d, (granularity, predicate)) => |
There was a problem hiding this comment.
Just a picky comment, could we split these long lines into shorter ones?
|
Just a couple of minor comments about long lines :) Code looks great! Thanks @noelmarkham!! |
|
Addressed changes, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows importing of a
Granularitytype to restrict the precision of a generated date.The import takes the form:
For instance:
These imports are optional, not including it gives maximum precision.
This works both for the
genDateTime(Joda) andgenZonedDateTime(Jdk8) generators, but also on thegenDateTimeWithinRangemethod - allowing both generation with a specific range of time, to a certain precision, for both Joda and Jdk8 setups.Resolves #3