Generalize timeout tests. Fix twitter timeout. #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I generalized the tests which check if a
FetchMonadError
can timeout aQuery
.Before, two tests didn't actually run for both
TwitterFuture
andRerunnable
, because they were asynchronous and the tests stopped before the results were returned. One of these tests failed forTwitterFuture
andRerunnable
.When a
Timout
was set for a asynchronousQuery
it would always time out.Timer.Nil
was used to execute the timeouts, which invokes tasks immediately. I changed it toJavaTimer
which is based onjava.util.Timer
(which is already used in the timeout forscala.concurrent.Future
).