Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.0.0 #179

Merged
merged 10 commits into from
Feb 27, 2019
Merged

Release 1.0.0 #179

merged 10 commits into from
Feb 27, 2019

Conversation

purrgrammer
Copy link
Contributor

:shipit:

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #179 into master will decrease coverage by 3.37%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   96.57%   93.19%   -3.38%     
==========================================
  Files           6        6              
  Lines         175      191      +16     
  Branches        5        6       +1     
==========================================
+ Hits          169      178       +9     
- Misses          6       13       +7
Impacted Files Coverage Δ
shared/src/main/scala/fetch.scala 93.02% <56.25%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db67321...ef26046. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 26, 2019 •
edited
Loading

Codecov Report

Merging #179 into master will decrease coverage by 3.37%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   96.57%   93.19%   -3.38%     
==========================================
  Files           6        6              
  Lines         175      191      +16     
  Branches        5        6       +1     
==========================================
+ Hits          169      178       +9     
- Misses          6       13       +7
Impacted Files Coverage Δ
shared/src/main/scala/fetch.scala 93.02% <56.25%> (-3.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db67321...ef26046. Read the comment docs.

raulraja
raulraja approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work and congrats to everyone that made Fetch possible!

juanpedromoreno
juanpedromoreno approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐️

@purrgrammer purrgrammer merged commit 0edb37f into master Feb 27, 2019
@purrgrammer
Copy link
Contributor Author

:shipit:

@purrgrammer purrgrammer deleted the release-notes branch February 27, 2019 09:50
bijancn pushed a commit to bijancn/fetch that referenced this pull request Sep 19, 2019
@purrgrammer
Merge pull request xebia-functional#179 from 47deg/release-notes
19f6e38 
Release 1.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@raulraja raulraja raulraja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purrgrammer @raulraja @juanpedromoreno