Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain classes should be traits #450

Open
dcsobral opened this issue Apr 10, 2020 · 1 comment
Open

Domain classes should be traits #450

dcsobral opened this issue Apr 10, 2020 · 1 comment

Comments

@dcsobral
Copy link
Contributor

Github feature flags sometimes add fields to objects. While having the domain case classes as final is good, they should be implementations instead of being used directly in the type signature of the algebras. That way, one can extend an algebra to return more data without adding a new method.

And while the contravariant nature of parameters prevent us from doing the same for data sent to github, it would still be helpful to be able to extend those traits as a guideline.

@dcsobral
Copy link
Contributor Author

Note that my motive is to make the tagless final design achieve its goals. This is not an abstract issue for me, as I run into this very problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant