-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for React Router 7 #782
Comments
I don't get it, their docs mention it's not a breaking change, but changing the package name is the breakiest of the changes.. I'd say the best way to handle this in nuqs is to have two adapters, one for v6 and one for v7:
In the next major update of nuqs, we can then swap what |
Any updates when will this be implemented? |
Would you like to open a PR? |
I have open a PR but this is my very first time opening a PR to an open source project. So feel free to add feedbacks because I know there will be a lot |
Thanks and congrats for your first PR! ❤️ |
@franky47, could you please share when you could ship this? |
@omarkhatibco hopefully this week, now that tests have been merged in #807, they confirmed a few issues:
|
🎉 This issue has been resolved in version 2.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Context
What's your version of
nuqs
?What framework are you using?
Which version of your framework are you using?
Description
React router v7 was now released. See: https://reactrouter.com/
It seems
react-router-dom
is no longer a thing, everything now lives insidereact-router
. With that said, the existing adapter is no longer compatible with react router 7.Reproduction
The text was updated successfully, but these errors were encountered: