Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate rolls #32

Open
bhollis opened this issue Jul 30, 2020 · 1 comment
Open

Duplicate rolls #32

bhollis opened this issue Jul 30, 2020 · 1 comment

Comments

@bhollis
Copy link
Contributor

bhollis commented Jul 30, 2020

There are over 9000 duplicate rolls in the voltron.txt file that get dropped when the file is parsed. It'd be great to filter those out ahead of time as part of generating the overall file.

@whyayala
Copy link
Contributor

I disagree. While I believe dim will only use the first match it finds in the file, having context of the number of times a roll was recommended can be meaningful. I am working on parsing out the voltron file to split it into seperate lists for mkb and controller users. I also want to be able to apply a "weight" to rolls signifying how many times they occured and include that info in the wishlist notes. I think that could provide more insight to players on how optimal their roll is.

repo here: https://github.com/whyayala/dim-wishlist-cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants