Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define defaultClientSecret as Empty when using a PKCE #6

Open
FDuhen opened this issue Aug 30, 2021 · 1 comment
Open

Define defaultClientSecret as Empty when using a PKCE #6

FDuhen opened this issue Aug 30, 2021 · 1 comment

Comments

@FDuhen
Copy link

FDuhen commented Aug 30, 2021

Hey !
Thank you for this example project and the associated lib.
A quick improvement would be to define the defaultClientSecret value as Empty or Null when requesting a PKCE token.
If the value is set to a placeholder, the data client_secret will be added in the authent query and it'll fail.
@jhancock4d
Copy link
Contributor

client_secret isn't filled in in the sample to intentionally require you to put in usable credentials one way or another. Since I don't have a public server that I can just link to without having special specific credentials I can't just put anything in so this was my way if requiring you to update the sample before you test run it so that it worked against your environment.

PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FDuhen @jhancock4d