Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: load chain PEM file and optionally include the KEY as well #36

Closed
TomFreudenberg opened this issue Jun 9, 2021 · 9 comments
Closed
Assignees
Milestone

Comments

@TomFreudenberg
Copy link
Member

TomFreudenberg commented Jun 9, 2021

With PR #33 @ocha has enabled the load of a CHAIN PEM file.

When reading DigiCert PEM creation you will find also some information that the key file maybe already included in the chain.

This should be get handled here as well.

Last but not least from Ruby/OpenSSL there is also a PR about reading a CHAIN PEM file at ruby/openssl#441

Checkout how to use this once it is deployed.

@TomFreudenberg TomFreudenberg added this to the 3.0.y milestone Jun 9, 2021
@TomFreudenberg TomFreudenberg self-assigned this Jun 9, 2021
@TomFreudenberg
Copy link
Member Author

Checkout also this revert commit:

ruby/openssl@23b0704

@TomFreudenberg
Copy link
Member Author

TomFreudenberg commented Jun 9, 2021

Checkout this bash file to create chained / signed PEM files

https://github.com/4commerce-technologies-AG/midi-smtp-server/blob/master/test/data/test-cert.build.sh

@TomFreudenberg
Copy link
Member Author

@ocha

Hi Luri,

I appended also the option to include the key in the PEM file

and wrote some tests for the chained PEM files.

Could you please also run some tests if that fits.

I will prepare a new release after your feedback.

Cheers
Tom

@TomFreudenberg
Copy link
Member Author

@ocha

You do not need to write additional tests - I just ask you to test this master branch with your current setup - if all is fine

@TomFreudenberg
Copy link
Member Author

Hey @gencer

I am just a moment before publishing a new release. (3.0.2)

It would be nice if you have the option to run the latest master branch once on your side and put me some feedback. I do not expect any issues 😉

Best wishes and hope you are well
Tom

@gencer
Copy link
Contributor

gencer commented Jun 11, 2021

@TomFreudenberg Thanks for the heads up. I'll test and report back to you with my application.

@iuri-gg
Copy link
Contributor

iuri-gg commented Jun 11, 2021

Hey @TomFreudenberg.

I just tested latest master branch with my setup and everything works as expected. I did not test explicitly embedding private key into the PEM file. I did test cert chain and validation from smtp client.

Thanks!

@gencer
Copy link
Contributor

gencer commented Jun 11, 2021

@TomFreudenberg Sorry for my late reply. At my first test, I got errors on client-side then on server-side. However, all of them caused by certificate chains. (My mistake)

Currently, on master branch I am able to receive all messages as usual on production environment. I've already deployed master branch on all prod machines.

No issues so far. It just works™.

@TomFreudenberg
Copy link
Member Author

Hey guys,

thanks for your feedback - so the new release will be pushed.

Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants