-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: load chain PEM file and optionally include the KEY as well #36
Comments
Checkout also this revert commit: |
Checkout this bash file to create chained / signed PEM files |
Hi Luri, I appended also the option to include the key in the PEM file and wrote some tests for the chained PEM files. Could you please also run some tests if that fits. I will prepare a new release after your feedback. Cheers |
You do not need to write additional tests - I just ask you to test this master branch with your current setup - if all is fine |
Hey @gencer I am just a moment before publishing a new release. (3.0.2) It would be nice if you have the option to run the latest master branch once on your side and put me some feedback. I do not expect any issues 😉 Best wishes and hope you are well |
@TomFreudenberg Thanks for the heads up. I'll test and report back to you with my application. |
Hey @TomFreudenberg. I just tested latest master branch with my setup and everything works as expected. I did not test explicitly embedding private key into the PEM file. I did test cert chain and validation from smtp client. Thanks! |
@TomFreudenberg Sorry for my late reply. At my first test, I got errors on client-side then on server-side. However, all of them caused by certificate chains. (My mistake) Currently, on No issues so far. It just works™. |
Hey guys, thanks for your feedback - so the new release will be pushed. Closing this |
With PR #33 @ocha has enabled the load of a CHAIN PEM file.
When reading DigiCert PEM creation you will find also some information that the key file maybe already included in the chain.
This should be get handled here as well.
Last but not least from Ruby/OpenSSL there is also a PR about reading a CHAIN PEM file at ruby/openssl#441
Checkout how to use this once it is deployed.
The text was updated successfully, but these errors were encountered: