You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
UPDATE It looks like the newest https://github.com/actions/github-script uses NodeJS 20, so dropping it might be less critical, though probably still preferable - mostly because it doesn't really offer much, see our availability monitoring script where we do just fine without it...
However, I suggest that rather than invest the time in upgrading, we take this opportunity to encapsulate the python logic into the NodeJS (auto-pr) script. There isn't really a need for 2 separate scripts, and most of our devs know JS better than python. Also less CI work (only need to install node runtime/dependencies, etc). It also looks like the NPM package is more mature (its 1.X.Y version has been release 2 years ago: https://www.npmjs.com/package/openai?activeTab=versions).
While we're at it, I think we can also move off github-script to regular NodeJS. The former is limited to Node16 (missing some useful features) and has an annoying package adding experience (custom require method). Its main advantage can be easily obtained by using https://octokit.github.io/rest.js/v20 directly. The rest of the context is provided in environment variables anyway by the GH actions runtime.
Finally, it it's always better to use TypeScript than JavaScript.
The text was updated successfully, but these errors were encountered:
ohadschn
changed the title
Upgrade to OpenAI 1.0.x
Upgrade to OpenAI 1.0.x + organize scripts (remove Python, use NodeJS 20 directly instead of github-script)
Nov 8, 2023
ohadschn
changed the title
Upgrade to OpenAI 1.0.x + organize scripts (remove Python, use NodeJS 20 directly instead of github-script)
Organize scripts (remove Python, use NodeJS 20 directly instead of github-script)
Nov 8, 2023
ohadschn
changed the title
Organize scripts (remove Python, use NodeJS 20 directly instead of github-script)
Organize scripts (remove Python, use NodeJS 20+ directly instead of github-script)
Nov 8, 2023
ohadschn
changed the title
Organize scripts (remove Python, use NodeJS 20+ directly instead of github-script)
Organize scripts (remove Python, use NodeJS 20+ directly instead of github-script, move to TypeScript)
Nov 19, 2023
UPDATE It looks like the newest https://github.com/actions/github-script uses NodeJS 20, so dropping it might be less critical, though probably still preferable - mostly because it doesn't really offer much, see our availability monitoring script where we do just fine without it...
OpenAI for python just reached GA (1.0.x) this week: (https://pypi.org/project/openai/1.1.1/#history)
Breaking changes / migration guide: openai/openai-python#631
However, I suggest that rather than invest the time in upgrading, we take this opportunity to encapsulate the python logic into the NodeJS (auto-pr) script. There isn't really a need for 2 separate scripts, and most of our devs know JS better than python. Also less CI work (only need to install node runtime/dependencies, etc). It also looks like the NPM package is more mature (its 1.X.Y version has been release 2 years ago: https://www.npmjs.com/package/openai?activeTab=versions).
While we're at it, I think we can also move off
github-script
to regular NodeJS. The former is limited to Node16 (missing some useful features) and has an annoying package adding experience (customrequire
method). Its main advantage can be easily obtained by using https://octokit.github.io/rest.js/v20 directly. The rest of the context is provided in environment variables anyway by the GH actions runtime.Finally, it it's always better to use TypeScript than JavaScript.
The text was updated successfully, but these errors were encountered: