Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golangci-lint reports several linting errors #10

Closed
anurag-rajawat opened this issue Dec 3, 2023 · 0 comments · Fixed by #11
Closed

Golangci-lint reports several linting errors #10

anurag-rajawat opened this issue Dec 3, 2023 · 0 comments · Fixed by #11
Assignees
Labels
bug Something isn't working

Comments

@anurag-rajawat
Copy link
Collaborator

Fix linting violations identified by golangci-lint, such as:

controllers/policy/network_policy.go:96:27: Error return value of `utils.ApplyOrUpdatePolicy` is not checked (errcheck)
        utils.ApplyOrUpdatePolicy(ctx, c, policy, policy.Name)
                                 ^
controllers/policy/network_policy.go:87:6: func `createCiliumNetworkPolicy` is unused (unused)
func createCiliumNetworkPolicy(ctx context.Context, intent *intentv1.SecurityIntent) *ciliumv2.CiliumNetworkPolicy {
     ^
controllers/policy/network_policy.go:91:6: func `createKubeArmorNetworkPolicy` is unused (unused)
func createKubeArmorNetworkPolicy(ctx context.Context, intent *intentv1.SecurityIntent) *kubearmorpolicyv1.KubeArmorPolicy {
     ^
controllers/policy/network_policy.go:95:6: func `applyCiliumNetworkPolicy` is unused (unused)
func applyCiliumNetworkPolicy(ctx context.Context, c client.Client, policy *ciliumv2.CiliumNetworkPolicy) {
@nandhued nandhued added this to NIMBUS Dec 8, 2023
@nandhued nandhued moved this to 🆕 New in NIMBUS Dec 8, 2023
@nandhued nandhued moved this from 🆕 New to 📋 Backlog in NIMBUS Dec 8, 2023
@nandhued nandhued added the bug Something isn't working label Dec 8, 2023
@nandhued nandhued moved this from 📋 Backlog to 🏗 In progress in NIMBUS Dec 8, 2023
@nandhued nandhued moved this from 🏗 In progress to 👀 In review in NIMBUS Dec 8, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in NIMBUS Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants