feat: replace request with node-fetch, #100 #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Node fetch returns a different instance when used with `json:false` argument
MrSwitch
force-pushed
the
node-fetch
branch
from
458ca8a
to
eb9eb74
Compare
ikhemissi
approved these changes
Sep 29, 2021
| // How to handle JSON | ||
| // Explitly request JSON response | ||
| const convertToJSON = json ?? true | ||
| if (convertToJSON) { |
There was a problem hiding this comment.
I think you haven't noted the nullish coalescing ?? true
Co-authored-by: Iheb KHEMISSI <iheb.khemissi+github@gmail.com>
5app-Machine
added a commit
that referenced
this pull request
Sep 29, 2021
# [1.0.0](v0.3.1...v1.0.0) (2021-09-29) ### Features * replace request with node-fetch, [#100](#100) ([#105](#105)) ([337df02](337df02)) ### BREAKING CHANGES * Node fetch returns a different instance when used with `json:false` argument * chore: typo src/api.js Co-authored-by: Iheb KHEMISSI <iheb.khemissi+github@gmail.com> Co-authored-by: Iheb KHEMISSI <iheb.khemissi+github@gmail.com>
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100