Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-integrate an open source acknowledgements section #333

Closed
nickoneill opened this issue Sep 6, 2023 · 1 comment · Fixed by #412
Closed

Re-integrate an open source acknowledgements section #333

nickoneill opened this issue Sep 6, 2023 · 1 comment · Fixed by #412
Milestone
2.1

Comments

@nickoneill
Copy link
Member

Currently broken and being removed (#332), we should still list the open source contributions though. Since we're reworking a lot of the deps for the SwiftUI design (#331), let's revisit for that project rather than try to list the current UIKit deps that will mostly be removed.
@nickoneill nickoneill mentioned this issue Sep 6, 2023
Merged
@nickoneill nickoneill added this to the 2.0 milestone Nov 5, 2023
@nickoneill nickoneill mentioned this issue Nov 11, 2023
Closed
47 tasks
@nickoneill nickoneill modified the milestones: 2.0, 2.1 Dec 14, 2023
@cselin
Copy link
Collaborator

cselin commented Jan 3, 2024 •
edited
Loading

@nickoneill thoughts about using this? It seems to be pretty up-to-date and has dozens of forks and hundreds of stars. I can integrate if you sign off.
This was actually pretty easy so I went ahead and implemented it 😃

@cselin cselin linked a pull request Jan 3, 2024 that will close this issue
Add open source acknowledgements #412
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Add open source acknowledgements 5calls/ios
2 participants
@nickoneill @cselin