Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility pass #365

Closed
Tracked by #331
nickoneill opened this issue Nov 11, 2023 · 8 comments
Closed
Tracked by #331

Accessibility pass #365

nickoneill opened this issue Nov 11, 2023 · 8 comments
Assignees
Milestone

Comments

@nickoneill
Copy link
Member

No description provided.

@heathermh
Copy link
Collaborator

Reminders: #374

@heathermh
Copy link
Collaborator

My impact: #375

@heathermh
Copy link
Collaborator

About: #376

@nickoneill nickoneill added this to the 2.0 milestone Dec 10, 2023
@heathermh
Copy link
Collaborator

@nickoneill and @cselin I'm testing out possibly combining ContactListItemCompact and ContactListItem. The more I look at them, the more I realize they're super similar and it's better to handle their accessibility all at once. Plus, hopefully we can get some design benefits from combining them. One particular bit is the background color for each contact person we list. Please check out the screen grabs below, and let me know if you like them with the grey background, or without the grey background? Always open to other thoughts, too.

These are the IssueContactDetail view and it uses the regular size ContactListItem. I'll include light/dark with and without the grey background.
IssueContactGrayLightIssueContactNoGrayLight
IssueContactGrayDarkIssueContactNoGrayDark

These are the IssueDone view that uses the compact size, light/dark with and without the grey background.
DoneGrayLightDoneNoGrayLight
DoneGrayDarkDoneNoGrayDark

@nickoneill
Copy link
Member Author

@heathermh let's do without as the default. We can add a background when calling ContactListItem like in IssueContactDetail where I think it looks better but leave it out on IssueDone where it's not needed.

@nickoneill
Copy link
Member Author

Do you know when we'll see the next iteration of these improvements @heathermh?

@heathermh
Copy link
Collaborator

@nickoneill I'm currently focusing on getting report(outcome) in OutcomesView to work for VO users. Have a working theory to try, so may have an update this week/weekend/early next week.

@heathermh
Copy link
Collaborator

Dashboard, etc: #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants