Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Better invalid location handling #61

Open
nickoneill opened this issue Sep 5, 2017 · 2 comments
Open

Better invalid location handling #61

nickoneill opened this issue Sep 5, 2017 · 2 comments

Comments

@nickoneill
Copy link
Member

Currently if you arrive at an issue page with an invalid location (i.e. outside of the US, or somewhere that google civic can't determine any reps) the page is blank because of the thrown invalid address error.

If I comment out the thrown error, the call appears without a contact but with the outcome buttons.

We should message an invalid address in the location selector, but also in the call details. And remove the outcome buttons since they don't correspond to a contact.

@cdoremus
Copy link
Contributor

cdoremus commented Sep 6, 2017

The outcome buttons are removed in PR #64 if there are no contacts affiliated with an issue.

@cdoremus
Copy link
Contributor

cdoremus commented Sep 8, 2017

PR #64 seems to have fixed this issue (not just the outcome buttons), but we're waiting for verification from the person who reported it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants