fix: add containerCssClass to RowMove to fix cell styling issue with icons
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- prior to this PR we only had a `cssClass` option but that was adding the CSS classes directly on the `.slick-cell` container and this was maybe ok before we added SlickGrid icons (SVG) but it's causing issue now as per attached printscreens. To address this, let's add a `cellContainerCssClass` that will keep "cell-reorder dnd" CSS classes on the cell container, but let's use the `cssClass` as a new <div> inside the slick-cell container, so this way our icon is separate from the container and won't affect/conflict with its styling
ghiscoding
changed the title
cellContainerCssClass to fix cell styling issue with iconscontainerCssClass to fix cell styling issue with icons
ghiscoding
changed the title
containerCssClass to fix cell styling issue with iconscontainerCssClass to RowMove to fix cell styling issue with icons
ghiscoding
pushed a commit
that referenced
this pull request
Nov 1, 2023
- this basically rolls back PR #865
ghiscoding
added a commit
that referenced
this pull request
Nov 1, 2023
* fix: regression with RowMoveManager, row could no longer be moved - this basically rolls back PR #865
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cssClassoption but that was adding the CSS classes directly on the.slick-cellcontainer and this was maybe ok before we added SlickGrid icons (SVG) but it's causing issue now as per attached printscreens. To address this, let's add acellContainerCssClassthat will keep "cell-reorder dnd" CSS classes on the cell container, but let's use thecssClassas a new<div>inside the slick-cell container, so this way our icon is totally separate from the slick-cell container and won't affect/conflict with its stylingin print screens below, we can see that the border under each Row Move (drag) icon is being removed for some reason, that was a styling conflict as described above
before
after