Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add more checks around cached rows #881

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix: add more checks around cached rows #881

merged 3 commits into from
Oct 25, 2023

Conversation

ghiscoding
Copy link
Collaborator

  • there were many assumptions that certain objects/fields were defined and calls on them were being made but it could happen in certain rare case that these row cache fields are actually undefined and that threw errors on our end, so this PR adds more checks before using any of these row cache objects/arrays

ghiscoding-SE and others added 3 commits October 24, 2023 18:58
@ghiscoding-SE
fix: add more checks around cached rows
3fee104 
- there were many assumptions that certain objects/fields were defined and calls on them were being made but it could happen in certain rare case that these row cache fields are actually undefined and that threw errors on our end, so this PR adds more checks before using any of these row cache objects/arrays
@ghiscoding
chore: use proper object ref
33b90c4
@ghiscoding
chore: refactor code with optional chaining
d95f838
@ghiscoding ghiscoding merged commit fb2fa28 into master Oct 25, 2023
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/row-caches-exists branch October 25, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @ghiscoding-SE