Feat: shadow dom, fixes issue #889 #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
megatron0000
commented
Oct 28, 2023
•
megatron0000
commented
- Adds an option to Slick.Grid to make it work when inside a shadow DOM tree. It did not work because the shadow DOM is not affected by external stylesheets, so to fix this we have to add dynamic stylesheets directly inside the shadow DOM.
- fixes issue slickgrid breaks when using shadow DOM because slickgrid relies on global CSS in the <head> #889
|
Does the new example make sense where it is ? (i.e. next to the basic example). If there are problems in this proposed solution, I'd be happy to review |
ghiscoding
requested changes
Oct 28, 2023
|
looking good, we can add it to the list of Examples in the Examples Wiki after it gets merged |
ghiscoding
approved these changes
Oct 30, 2023
ghiscoding
pushed a commit
that referenced
this pull request
Oct 30, 2023
- backported from PR #890 to support the creation of SlickGrid inside ShadowDOM
ghiscoding
added a commit
that referenced
this pull request
Oct 30, 2023
|
@megatron0000 thanks for the contribution, this is now available in today's release v5.4.0. BTW, I'm not sure all controls/plugins will all work properly because of some body selector and event listeners. I never use ShadowDOM so if you find some issues please contribute again 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.