Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: interactions remove callback 2x call & add event listeners to body #918

Merged
merged 1 commit into from
Nov 20, 2023
Merged

fix: interactions remove callback 2x call & add event listeners to body #918

merged 1 commit into from
Nov 20, 2023

Conversation

ghiscoding
Copy link
Collaborator

  • the onResize was called twice, that was probably a copy+paste problem
  • the event listener should be on document.body instead of just document

@ghiscoding-SE
fix: interactions remove callback 2x call & add event listeners to body
540a820 
- the `onResize` was called twice, that was probably a copy+paste problem
- the event listener should be on `document.body` instead of just `document`
@ghiscoding ghiscoding merged commit a37d263 into master Nov 20, 2023
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/interactions-on-document-body branch November 20, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghiscoding @ghiscoding-SE