Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revamp all cell selection range with key combos, fixes #935 #940

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Dec 2, 2023

the previous key combo were incorrect, the new combo is the following

  • Shift+Home will select from current cell position to first cell horizontally
  • Shift+End will select from current cell position until the last cell horizontally
  • Ctrl+Shift+Home will select everything that is on the left side of current cell position and everything on top current position (horizontally left until first cell & vertically left until first row)
  • Ctrl+Shift+End will select everything that is on the right side of current cell position and everything on bottom current position (horizontally right until last cell & vertically right until last row)
  • fixes Cell selection minor inconsistency #935
    The other key combos (with PageUp/PageDown/ArrowLeft/ArrowRight) remains the same

TODOS

  • test locally and manually
  • fix and add Cypress E2E tests
Shift+Home

image

Shift+End

image

Ctrl+Shift+Home

image

Ctrl+Shift+End

image

the previous key combo were incorrect, the new combo is the following
- `Shift+Home` will select from left most (index 0) to current cell position horizontally
- `Shift+End` will select from current cell position until the last cell horizontally
- `Ctrl+Shift+Home` will select everything that is on the left side of current cell position and everything on top current position (horizontally left until first cell & vertically left until first row)
- `Ctrl+Shift+End` will select everything that is on the right side of current cell position and everything on bottom current position (horizontally right until last cell & vertically right until last row)
@ghiscoding ghiscoding merged commit c44eda8 into master Dec 2, 2023
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/spreadsheet-selection-key-combos branch December 2, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell selection minor inconsistency
2 participants