Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when onResizeStart return false it should stop #978

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

ghiscoding
Copy link
Collaborator

@ghiscoding ghiscoding commented Jan 17, 2024

  • when onResizeStart returns false, for example when editor commitCurrentEdit() fails, then the column resize shouldn't be allowed

SlickGrid/src/slick.grid.ts

Lines 1939 to 1943 in ab634eb

onResizeStart: (e, resizeElms): boolean | void => {
const targetEvent = (e as TouchEvent).touches ? (e as TouchEvent).changedTouches[0] : e;
if (!this.getEditorLock()?.commitCurrentEdit()) {
return false;
}

brave_JDQMdK491W

- when `onResizeStart` returns `false`, for example when editor `commitCurrentEdit()` fails, then the column resize shouldn't be allowed
@ghiscoding ghiscoding merged commit 8c659c9 into master Jan 17, 2024
2 checks passed
@ghiscoding ghiscoding deleted the bugfix/resize-start-false branch January 17, 2024 05:27
ghiscoding added a commit that referenced this pull request Jan 17, 2024
- when `onDragInit` returns `false` then the row or cell dragging shouldn't be allowed
- this is similar to previous PR #978
ghiscoding added a commit that referenced this pull request Jan 17, 2024
- when `onDragInit` returns `false` then the row or cell dragging shouldn't be allowed
- this is similar to previous PR #978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant