Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): convert for..in to Object.keys().forEach for better perf #987

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

ghiscoding
Copy link
Collaborator

  • as mentioned in this Stack Overflow, Object.keys().forEach are quicker than for..in because the latter also loops through prototype chain.

@ghiscoding ghiscoding merged commit c0f7b7c into master Jan 27, 2024
2 checks passed
@ghiscoding ghiscoding deleted the perf/for-in-foreach branch January 27, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant