m doesn't select to the matching enclosing under the cursor.

[leira]

Key m doesn't behaves the same as in Kakoune. This is an example:

{ a { b } c }
----------------
^ the cursor is here

Currently, the cursor is on the first {. In Kakoune, if m is pressed, it will select from the first { to the last } after c, and the cursor stops at the last }. When m is pressed again, the selection won't change, the cursor jumps back to the first {. Keep pressing ms, the selection stays the same, the cursor ping-pongs between the 2 ends of the selection.

In Dance, if m is pressed, it selects from the second { after a to the first } after b, and the cursor stops at the first }. When m is pressed again, it selects the from the first { to the last }, and cursor jumps to the first {. The selection changes. And keep pressing ms, the selection keeps changing.

It seems, rather than starting from the character under the cursor to find a character to enclose with, Dance starts from the next character. Is this behavior difference intentional? Is there some technical limitations?

[leira]

I saw this comment in function enclosing(). It looks like it is trying to be consistent with Kakoune. And the details of the behavior matches my understanding of the Kakoune m.

dance/src/commands/seek.ts

Lines 137 to 141 in 9265b42

	// This command intentionally ignores repetitions to be consistent with
	// Kakoune.
	// It only finds one next enclosing character and drags only once to its
	// matching counterpart. Repetitions > 1 does exactly the same with rep=1,
	// even though executing the command again will jump back and forth.

[71]

Indeed, there was a problem in the implementation. There are still some buggy edge cases, but 6603df9 fixes some of them.

[leira]

Thanks! Is there an issue opened to document these edge cases?

[71]

Not yet, no. Feel free to open one (preferably with test cases) if you hit any of them.