Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade static site generator #108

Closed
joshbruce opened this issue Nov 14, 2021 · 0 comments · Fixed by #125
Closed

Upgrade static site generator #108

joshbruce opened this issue Nov 14, 2021 · 0 comments · Fixed by #125

Comments

@joshbruce
Copy link
Member

Describe the feature

The static site generator won't be able to generate the site correctly for a moment, I don't think.

  • Canonical urls #107: Introduced the creation of canonical URLs. This is based on the .env APP_URL value. This will be different locally than in production. (Could use relative URLs locally.)
  • The sitemap work also uses canonical URLs.

Why is this feature necessary?

The dynamic site is coming along nicely.

However, the progress is demonstrating some of the limitations in the static site generator code.

Describe alternatives you've considered

Does this really constitute being broken?

The static site isn't sent to VCS and would be generated using a deployment script near the production .env file with the correct APP_URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant