Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid supported color modes #22

Closed
8none1 opened this issue Jun 21, 2024 · 3 comments · Fixed by #25
Closed

Invalid supported color modes #22

8none1 opened this issue Jun 21, 2024 · 3 comments · Fixed by #25
Assignees

Comments

@8none1
Copy link
Owner

8none1 commented Jun 21, 2024

The latest version (not yet released) triggers this error:

2024-06-21 15:22:03.265 WARNING (MainThread) [homeassistant.components.light] None (<class 'custom_components.lednetwf_ble.light.LEDNETWFLight'>) sets invalid supported color modes {<ColorMode.BRIGHTNESS: 'brightness'>, <ColorMode.COLOR_TEMP: 'color_temp'>, <ColorMode.HS: 'hs'>}, this will stop working in Home Assistant Core 2025.3, please create a bug report at https://github.com/raulgbcr/lednetwf_ble/issues

This means we need to port everything to using HS colorspaces instead of RGB.

I expect this is because it will remove the need to track colour and brightness separately. It makes sense but it will be quite a significant change.

@raulgbcr
Copy link
Collaborator

Yeah, I had that in the radar, there are some very angry looking comments on the places this has to be changed that I identified. It's on the list of things to do some time in the future, unless you wanna go ahead and tackle it hehe

@raulgbcr
Copy link
Collaborator

raulgbcr commented Aug 10, 2024

Added a fix for this on 00c54de and 2856e16 on a new test branch, initial testing seems promising on my side, hopefully was a minor thing I introduced on the 2024.2 update and should be fixed with this

@8none1
Copy link
Owner Author

8none1 commented Sep 9, 2024

Sorry, I haven't forgotten about this, just been a bit busy with other things. I will pick this up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants