Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dark mode #295

Closed
rvanlaak opened this issue Jan 28, 2020 · 6 comments
Closed

Support dark mode #295

rvanlaak opened this issue Jan 28, 2020 · 6 comments

Comments

@rvanlaak
Copy link
Contributor

Q A
Symfony version 5.0.3
Bundle version 8.0.0

The following two css rules cause problems for dark mode:

image

image

Before

image

After removing CSS rules

What about removing the two lines?

image

@gregurco
Copy link
Member

Hello
Good observation! I'm not sure about removing, because we want to highlight these boxes, but I think dark mode adds some classes at the top level. I think we can add some rules, when dark mode is activated, colors will switch to dark style or light style, but not the same as background.

@rvanlaak
Copy link
Contributor Author

Would be good to follow the Symfony best practices on styling of the panels. Might be an idea to reuse the css classes from the profiler?

@gregurco
Copy link
Member

gregurco commented Jan 29, 2020

reuse the css classes

which classes do you mean? Could you give examples?

@rvanlaak
Copy link
Contributor Author

These can be found at symfony/web-profiler-bundle/Resources/views/Profiler/profiler.css.twig, which is the base CSS that gets imported when the pane would @WebProfiler/Profiler/base.html.twig.

As example I'd advise using:

  • .metric
  • .badge
  • .sf-tabs (also have js behavior)

@gregurco
Copy link
Member

gregurco commented Mar 3, 2020

@rvanlaak sorry for the late reply. I think the idea is good, to use classes provided by symfony.
Do you want to integrate that? PR is welcome.

@gregurco
Copy link
Member

gregurco commented Feb 5, 2022

Done in #316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants