Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MediaRecorder endCard #167

Open
jimib opened this issue May 18, 2021 · 1 comment
Open

Remove MediaRecorder endCard #167

jimib opened this issue May 18, 2021 · 1 comment

Comments

@jimib
Copy link

jimib commented May 18, 2021

I'm using the following configuration for the MediaRecorder:

XR8.MediaRecorder.configure({
    maxDurationMs: 5000,
    maxDimension : 1024,
    enableEndCard : false
 });

The settings for maxDurationMs and maxDimension are working, but the end card on the video is still being applied.

@jimib
Copy link
Author

jimib commented May 18, 2021

Figured it out. It's because I was using the XRExtras MediaPreview which has a default configuration setup included:

const currentConfig = {
enableEndCard: true,
footerImageUrl: 'https://cdn.8thwall.com/web/img/almostthere/v2/poweredby-horiz-white-2.svg',
}

I had to call to configure and overwrite the default options on the XRExtras as every time that called updateConfig it would override my existing options. This worked:

XR8.MediaRecorder.configure({
    maxDurationMs: 5000,
    maxDimension : 1024,
    enableEndCard : false
 });
XRExtras.MediaRecorder.configure({enableEndCard:false});
XRExtras.MediaRecorder.initMediaPreview();

I'm not going to close this as I feel that either the documentation needs updating, or the defaults in the XTExtras need updating to match those in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant