Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XR Extras do not use colorManagement #191

Open
ephb opened this issue Nov 23, 2021 · 0 comments
Open

XR Extras do not use colorManagement #191

ephb opened this issue Nov 23, 2021 · 0 comments

Comments

@ephb
Copy link

ephb commented Nov 23, 2021

When using the colorManagement property in an a-scene there is a significant difference in brightness between a material created by using pbrMaterialComponent compared to a material component on a geometry node using the same textures. This also applies to the basicMaterialComponent.

The following explanation is what i assume is happening, please correct me if I am wrong:

The renderer in aframe supports a property called color management which enables a color managed linear workflow.
Upon creating a new material this sets the color encoding of the textures accordingly.

When one creates an aframe material and sets its texture trough the src attribute this happens automatically.

But when using pbrMaterialComponent with the same texture it appears much brighter. Supposedly because setting the encoding is not done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant