New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: modifyValue() calls that change the parcel type break in the reducer #118

Closed

dxinteractive opened this issue Oct 17, 2018 · 1 comment

Collaborator

dxinteractive commented Oct 17, 2018

To fix:

split out type checker if it's not generic enough to run on arbitrary values already
in modifyValue after value is returned, check it's parcel type. If different, generate a handleChange that will set() that value before passing up other changes

Collaborator Author

dxinteractive commented Oct 18, 2018

This problem is potentially able to happen on nested data. ParcelNodes should help identify these as they happen.

This was referenced Oct 24, 2018

Feature/bugfixes #127

Merged

Release/playful python #129

Merged

dxinteractive closed this as completed in

b3363ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment