Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to ChangeRequest #56

Closed
1 of 2 tasks
dxinteractive opened this issue Jun 25, 2018 · 1 comment
Closed
1 of 2 tasks

Add caching to ChangeRequest #56

dxinteractive opened this issue Jun 25, 2018 · 1 comment

Comments

@dxinteractive
Copy link
Collaborator

dxinteractive commented Jun 25, 2018

Part of the reason for making ChangeRequests is to make Parcels more performant, but hitting the reducer less often. There are two kinds of caching we can add

  • Cache calls to ChangeRequest.data() and invalidate the cache after every dispatch step
  • Pre-cache data after every dispatch step
This was referenced Jun 25, 2018
@dxinteractive
Copy link
Collaborator Author

Precache after every dispatch step is unnecessary for now, the reducer is more performance that it used to be, and the perf penalty for people not using modifyChange functions is perhaps a little too steep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant