Adding a simple integer enum causes invalid code to be generated

[jwatte]

What happened?

Start with the default "gqlgen init" project structure.
Add a simple type (here "foo.Mode") to the gql schema and gqlgen.yml
re-generate
get errors:

[18:32:56] jwatte@observe-1804:~/go/src/gqltest$ gqlgen generate
validation failed: packages.Load: /home/jwatte/go/src/gqltest/graph/generated/generated.go:2245:17:     ec.unmarshalInputMode undefined (type *executionContext has no field or method unmarshalInputMode)
/home/jwatte/go/src/gqltest/graph/generated/generated.go:2250:12: ec._Mode undefined (type *executionContext has no field or method _Mode)
/home/jwatte/go/src/gqltest/graph/generated/generated.go:2591:17: ec.unmarshalInputMode undefined (type *executionContext has no field or method unmarshalInputMode)
/home/jwatte/go/src/gqltest/graph/generated/generated.go:2599:12: ec._Mode undefined (type *executionContext has no field or method _Mode)

What did you expect?

I expected appropriate glue for this type to be generated, and no compile errors.

Minimal graphql.schema and models to reproduce

[18:33:04] jwatte@observe-1804:~/go/src/gqltest$ git diff gqlgen.yml graph/schema.graphqls foo/
diff --git a/gqlgen.yml b/gqlgen.yml
index 7c8361f..7feed76 100644
--- a/gqlgen.yml
+++ b/gqlgen.yml
@@ -54,3 +54,5 @@ models:
       - github.com/99designs/gqlgen/graphql.Int
       - github.com/99designs/gqlgen/graphql.Int64
       - github.com/99designs/gqlgen/graphql.Int32
+  Mode:
+    model: github.com/jwatte/go-gqltest/foo.Mode
diff --git a/graph/schema.graphqls b/graph/schema.graphqls
index f6e1bac..a0c3b28 100644
--- a/graph/schema.graphqls
+++ b/graph/schema.graphqls
@@ -7,6 +7,12 @@ type Todo {
   text: String!
   done: Boolean!
   user: User!
+  mode: Mode!
+}
+
+enum Mode {
+  One
+  Two
 }

 type User {
@@ -21,8 +27,9 @@ type Query {
 input NewTodo {
   text: String!
   userId: String!
+  mode: Mode
 }

 type Mutation {
   createTodo(input: NewTodo!): Todo!
-}
\ No newline at end of file
+}


[18:35:44] jwatte@observe-1804:~/go/src/gqltest$ cat foo/mode.go
package foo

type Mode int

const (
        One Mode = 1
        Two Mode = 2
)

versions

• gqlgen version?

v0.12.2

• go version?

go version go1.14 linux/amd64

• dep or go modules?

go mod

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[danduh]

@jwatte Have you solved this issue?

[FanFani4]

there are no resolvers generated for an input type (even with @fieldResolver(forceResolver: true) or specifying in gqlgen.yml) but if you add it manually it works just fine, but after any code generation your resolver will go to the bottom of the file and will be marked as unused (actually it is).

as an example:
schema.graphqls

enum UserRole {
  USER
  MODERATOR
  SUPER_MODERATOR
  ADMINISTRATOR
}

type Mutation {
  foo(in: TestInput!): TestType!
}

input TestInput {
  id: String!
  role: UserRole!
}

type TestType {
  id: String!
  role: UserRole!
}

domain/user.go

type Role int

const (
	RoleUser           Role = iota
	RoleModerator 
	RoleSuperModerator 
	RoleAdmin  
)


type TestInput struct {
	ID   string
	Role Role
}

type TestTypInpute struct {
	ID   string
	Role Role
}

code generation goes without errors - but in resolvers.go we have only the resolver for TestType

type testTypeResolver struct{ *Resolver }

// TestType returns generated.TestTypeResolver implementation.
func (r *Resolver) TestType() generated.TestTypeResolver { return &testTypeResolver{r} }

func (r *testTypeResolver) Role(ctx context.Context, obj *domain.TestType) (model.UserRole, error) {
	panic(fmt.Errorf("not implemented"))
}

in result we have an error when running the project
$ go run .
*resolver.Resolver does not implement generated.ResolverRoot (missing TestInput method)

if we add it manually - so that our resolvers go looks like

type accountResolver struct{ *Resolver }
type phoneResolver struct{ *Resolver }

// TestType returns generated.TestTypeResolver implementation.
func (r *Resolver) TestType() generated.TestTypeResolver { return &testTypeResolver{r} }

func (r *testTypeResolver) Role(ctx context.Context, obj *domain.TestType) (model.UserRole, error) {
	panic(fmt.Errorf("not implemented"))
}

// TestType returns generated.TestTypeResolver implementation.
func (r *Resolver) TestInput() generated.TestInputResolver { return &testInputResolver{r} }

func (r *testInputResolver) Role(ctx context.Context, obj *domain.TestInput, role model.UserRole) error {
	panic(fmt.Errorf("not implemented"))
}

type testTypeResolver struct{ *Resolver }
type testInputResolver struct{ *Resolver }

everything works fine , but after next code generation it is marked as unused but still working:

// !!! WARNING !!!
// The code below was going to be deleted when updating resolvers. It has been copied here so you have
// one last chance to move it out of harms way if you want. There are two reasons this happens:
//  - When renaming or deleting a resolver the old code will be put in here. You can safely delete
//    it when you're done.
//  - You have helper methods in this file. Move them out to keep these resolver files clean.
func (r *Resolver) TestInput() generated.TestInputResolver { return &testInputResolver{r} }
func (r *testInputResolver) Role(ctx context.Context, obj *domain.TestInput, role model.UserRole) error {
	panic(fmt.Errorf("not implemented"))
}

type testInputResolver struct{ *Resolver }

[frederikhors]

Can you please open an issue with a reproduction repo?

[FanFani4]

thanks for fast reply, here you go :

#1948

[FanFani4]

@frederikhors i opened a PR for this issue , can you please accept it ?
#1950

[frederikhors]

I cannot. The core team will evaluate ASAP.