Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Support the GraphQL Spec Updates #1678

Closed
JonasDoe opened this issue Oct 27, 2021 · 6 comments
Closed

Proposal: Support the GraphQL Spec Updates #1678

JonasDoe opened this issue Oct 27, 2021 · 6 comments
Labels
awaiting response enhancement New feature or request

Comments

@JonasDoe
Copy link
Contributor

After three years, the GraphQL specification got an update: https://github.com/graphql/graphql-spec/releases/tag/October2021

Would be nice if these updates would be supported sometimes in the future.

@wilhelmeek
Copy link
Contributor

This blog post does a really great job of listing some headline changes.

@wilhelmeek
Copy link
Contributor

@JonasDoe I've created 2 issues to address spec changes:

Is there anything else that was introduced that may also need to be implemented?

@wilhelmeek wilhelmeek added awaiting response enhancement New feature or request labels Nov 3, 2021
@JonasDoe
Copy link
Contributor Author

JonasDoe commented Nov 3, 2021

@wilhelmeek I think intermediate interfaces are missing yet, too.
I hope I didn't screw up when testing it, but I think at the moment the declaration of those intermediate interfaces (e.g. interface AnimalEdge implements Edge {...}) leads to Unexpected Name "implements"

@wilhelmeek
Copy link
Contributor

@JonasDoe nope you're absolutely right! This needs both a parser change and a gqlgen change. I've opened issues here:

@JonasDoe
Copy link
Contributor Author

JonasDoe commented Nov 3, 2021

Awesome, thank you! If it makes sense to close this issue here, feel free to do so! :)

@wilhelmeek
Copy link
Contributor

Thanks for raising @JonasDoe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting response enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants