Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of Apollo Tracing? #219

Closed
dtrinh50 opened this issue Jul 23, 2018 · 1 comment · Fixed by #404
Closed

Support of Apollo Tracing? #219

dtrinh50 opened this issue Jul 23, 2018 · 1 comment · Fixed by #404
Labels
enhancement New feature or request

Comments

@dtrinh50
Copy link

Hi, are there any plans to support Apollo Tracing? Not sure if it would belong in this library, but just wanted to check.
@ermik
Copy link

ermik commented Jul 25, 2018

@dtrinh50 I think one can implement the tracing spec by using context and number of middlewares that would collect the necessary data, then just adding an additional field extensions to the response payload. Look at the dataloader example using context.

@mathewbyrne mathewbyrne mentioned this issue Sep 7, 2018
Merged
@vektah vektah added the enhancement New feature or request label Oct 3, 2018
@vvakame vvakame mentioned this issue Oct 30, 2018
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add apollo-tracing support 99designs/gqlgen
3 participants
@ermik @vektah @dtrinh50