Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embed templates into source #2260

Closed
clayne11 opened this issue Jun 29, 2022 · 2 comments · Fixed by #2262
Closed

Embed templates into source #2260

clayne11 opened this issue Jun 29, 2022 · 2 comments · Fixed by #2262

Comments

@clayne11
Copy link
Contributor

What happened?

Using this library with Bazel is currently challenging for a number of reasons. One is the usage of packages.Load. The other is that the template files are not included in the binary.

genqlient recently made this change and not only is the API much nicer, it is much easier to consume with Bazel.

Are you open to a similar PR for gqlgen?

@frederikhors
Copy link
Collaborator

Please PR. Thanks.

@jamesthompson
Copy link

@clayne11 This would be very very welcome from me and I'm sure a bunch of others as well. Thanks a lot in advance if you're able to work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants