Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #2470: Incorrect response when errors occurred #2471

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

atzedus
Copy link
Contributor

@atzedus atzedus commented Dec 14, 2022

Fix issue #2470: Incorrect response when errors occurred

Old Result:

{
  "errors": [
    {
      "message": "some error",
      "path": [
        "Kids"
      ]
    }
  ],
  "data": null
}

After PR result:

{
  "errors": [
    {
      "message": "some error",
      "path": [
        "Kids"
      ]
    }
  ],
  "data": {
       "Kids": null,
       "Martials": [1, 2, 3, 4]
  }
}

@coveralls
Copy link

coveralls commented Dec 14, 2022

Coverage Status

Coverage decreased (-0.02%) to 75.647% when pulling 86c5659 on atzedus:issue-fix-2470 into 3008f4e on 99designs:master.

@atzedus atzedus changed the title Fix issue #2470 Draft: Fix issue #2470 Dec 14, 2022
@atzedus atzedus changed the title Draft: Fix issue #2470 Fix issue #2470 Dec 14, 2022
@StevenACoffman StevenACoffman changed the title Fix issue #2470 Fix issue #2470: Incorrect response when errors occurred Dec 14, 2022
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman StevenACoffman merged commit 5cb6e3e into 99designs:master Dec 14, 2022
@atzedus atzedus deleted the issue-fix-2470 branch December 14, 2022 17:54
atzedus pushed a commit to atzedus/gqlgen that referenced this pull request Mar 6, 2023
StevenACoffman pushed a commit that referenced this pull request Mar 7, 2023
* Revert "Fix issue #2470: Incorrect response when errors occurred (#2471)"

This reverts commit 5cb6e3e.

* Closes #2523 #2541

* misspell lint fix

---------

Co-authored-by: Roman A. Grigorovich <ragrigorov@mts.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants